Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of discoverage ttag functions from require #104

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

AlexMost
Copy link
Member

Original issue is here - ttag-org/ttag#44.
This PR makes it possible to discover ttag functions from require function calls

Example:

const { t } = require('ttag');

t`test`

will be extracted to

msgid "test"
msgstr ""

@Alxpy @vharitonsky @MrOrz @snowwm

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #104 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   96.45%   96.41%   -0.04%     
==========================================
  Files          14       14              
  Lines        1185     1200      +15     
  Branches      176      178       +2     
==========================================
+ Hits         1143     1157      +14     
- Misses         42       43       +1
Impacted Files Coverage Δ
src/plugin.js 96.46% <100%> (+0.18%) ⬆️
src/defaults.js 100% <100%> (ø) ⬆️
src/utils.js 94.94% <100%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa378e7...274c162. Read the comment docs.

@AlexMost AlexMost merged commit 0046abf into master Jul 20, 2018
@AlexMost AlexMost deleted the discover-by-require branch July 20, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant